Send real_name in quote notification emails #7736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The username was used in the quote notification emails instead of real_name. Fixes #7734
|
looks like the relevant info is in MEMBERNAME and that we may need to fix the relevant language string instead. |
|
No MEMBERNAME and QUOTENAME are different users Hello {MEMBERNAME}, You have been quoted in the post titled "{CONTENTSUBJECT}" by {QUOTENAME}, you can see the post here |
|
you right, sorry
…On Wed, Jun 14, 2023 at 11:00 PM BrickOzp ***@***.***> wrote:
No MEMBERNAME and QUOTENAME are different users
From the email template
Hello {MEMBERNAME},
You have been quoted in the post titled "{CONTENTSUBJECT}" by {QUOTENAME},
you can see the post here
—
Reply to this email directly, view it on GitHub
<#7736 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJNN44LSOEP7J2ICGNVXDXLKQHDANCNFSM6AAAAAAXMOC6WQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The username was used in the quote notification emails instead of real_name.
Fixes #7734