Installer & Upgrader int cleanup for mysql 8+ #7791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed by Shawn Bulen, [email protected]
Signed by Shawn Bulen, [email protected]
|
This seems to me 2.2 territory. We don't introduce database changes in patches, unless some policy change happened...? |
|
We're good. It's not a structural change. No code impact. These values aren't used at all. If it is technically in violation of a policy somewhere, we can rewrite that policy. |
|
I believe if you upgrade to mysql 8 with these, they are just ignored. So I agree its just aligning with MySQL 8 (and technically other RDBMS) to ignore the size on the int based fields, since they already explicitly have a size. MySQL did some funky logic with how to display it with the size specified and zerofill specified. See for more history https://dev.mysql.com/doc/refman/8.0/en/numeric-type-attributes.html |
jdarwood007
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #7173
Integer display width is deprecated:
https://dev.mysql.com/worklog/task/?id=13127
https://dev.mysql.com/doc/refman/8.0/en/numeric-type-attributes.html
https://stackoverflow.com/questions/58938358/mysql-warning-1681-integer-display-width-is-deprecated