Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calls integrate_autoload hook only once #7851

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Calls integrate_autoload hook only once #7851

merged 1 commit into from
Nov 6, 2023

Conversation

Sesquipedalian
Copy link
Member

Fixes #7850

@Sesquipedalian
Copy link
Member Author

We should probably merge this regardless, but I'd be curious to know what difference it makes to your performance benchmarks, @albertlast.

jdarwood007
jdarwood007 approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@jdarwood007 jdarwood007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only comment is if a integration hook is added temporarily live, it won't be captured here.

@Sesquipedalian Sesquipedalian force-pushed the autoloader_hook branch 2 times, most recently from eb5ec3b to ceb8c0a Compare November 5, 2023 23:44
@Sesquipedalian
Copy link
Member Author

Looks good. Only comment is if a integration hook is added temporarily live, it won't be captured here.

Good catch. I've just pushed a change that should help with that.

@Sesquipedalian Sesquipedalian merged commit 323322e into SimpleMachines:release-3.0 Nov 6, 2023
3 checks passed
@Sesquipedalian Sesquipedalian deleted the autoloader_hook branch November 6, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdarwood007 jdarwood007 jdarwood007 approved these changes

@live627 live627 Awaiting requested review from live627

@albertlast albertlast Awaiting requested review from albertlast

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sesquipedalian @jdarwood007