Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue rendering nested empty placeholders #6

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

robearlam
Copy link
Member

@robearlam robearlam commented Aug 6, 2024

Currently, empty Placeholders are not rendering the same HTML that JSS does. This PR updates the SDK's TagHelper to generate HTML that matches the same output from JSS.

Description / Motivation

When a Placeholder is rendered without any components loaded inside of it, it needs to be wrapped in a div to be correctly rendered in Pages and Experience Editor. The div being created by for this SDK is <div className=\"sc-empty-placeholder\"></div>

Testing

  • The Unit & Intergration tests are passing.
  • I have added the necesary tests to cover my changes.

Terms

@robearlam robearlam added the bug Something isn't working label Aug 6, 2024
@robearlam robearlam self-assigned this Aug 6, 2024
@robearlam robearlam marked this pull request as draft August 7, 2024 03:27
@robearlam robearlam marked this pull request as ready for review August 7, 2024 06:47
@robearlam robearlam marked this pull request as draft August 7, 2024 06:52
@robearlam robearlam marked this pull request as ready for review August 7, 2024 07:00
@sc-ivanlieckens sc-ivanlieckens added this to the Beta Release milestone Aug 8, 2024
@robearlam robearlam merged commit 4967f4b into main Aug 8, 2024
3 checks passed
@robearlam robearlam deleted the fix/empty-placeholder-handling branch August 8, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants