-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read data about selected integration connectors #141
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
This does bring to light how limiting our current multi-select implementation is. It would be nice to have the none logic built into the multi-select rather than handled in the GameContextParser but that's a larger refactor that should not be in this PR.
Yes, we likely need a new type of control (we only have two right now). Something that is a "none-able" multi-select which renders a special none button but mostly behaves like multi-select. Then we can handle it on the Prompt to specify to use that control type instead of multiselect. |
This change will read the data from the user and parse it into objects so that can be used in Outcomes later to make decisions on which tiles to show or which content recommendations to make.
Additionally, this fixes the Cypress tests so that they can incorporate the new question into the flow.