Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read data about selected integration connectors #141

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Conversation

jst-cyr
Copy link
Contributor

@jst-cyr jst-cyr commented Mar 12, 2024

This change will read the data from the user and parse it into objects so that can be used in Outcomes later to make decisions on which tiles to show or which content recommendations to make.

Additionally, this fixes the Cypress tests so that they can incorporate the new question into the flow.

@jst-cyr jst-cyr added the enhancement New feature or request label Mar 12, 2024
@jst-cyr jst-cyr self-assigned this Mar 12, 2024
Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sitecore-migration-game ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 4:47pm

Copy link
Contributor

@thomas-desmond thomas-desmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

This does bring to light how limiting our current multi-select implementation is. It would be nice to have the none logic built into the multi-select rather than handled in the GameContextParser but that's a larger refactor that should not be in this PR.

@jst-cyr jst-cyr merged commit 63bfac5 into main Mar 14, 2024
4 checks passed
@jst-cyr
Copy link
Contributor Author

jst-cyr commented Mar 14, 2024

This does bring to light how limiting our current multi-select implementation is. It would be nice to have the none logic built into the multi-select rather than handled in the GameContextParser but that's a larger refactor that should not be in this PR.

Yes, we likely need a new type of control (we only have two right now). Something that is a "none-able" multi-select which renders a special none button but mostly behaves like multi-select. Then we can handle it on the Prompt to specify to use that control type instead of multiselect.

@jst-cyr jst-cyr deleted the read-connectors-used branch March 14, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants