Found an issue when saving any kind of address, where the ID of the a… #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddress was removed by the diff function and caused the patch to fail. Extended the diff function to include an additional optional array of field names, that forces the diff function to always inclulde the listed fields.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
fixes #256 |
…sed inthe array where the value do not match
crhistianramirez
requested changes
Mar 15, 2024
There was a problem hiding this comment.
@jwsadler thanks for you pull request. Instead of changing the diff function, can we instead change updateOrderCloudAddress to use address.ID instead of fields.ID? This is why I think that option is a little bit better:
- Keeps diff functionality unchanged, name of function does what it says without exceptions
- Matches pattern already defined in the codebase. Buyer for example
- The request body sent to the API reflects the fields we truly want to change and nothing more. Current solution will needlessly send an "ID" field. Not a huge deal but better if we can avoid it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ddress was removed by the diff function and caused the patch to fail.
Extended the diff function to include an additional optional array of field names, that forces the diff function to always inclulde the listed fields.