-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate 'Edge Development mode with No Docker' #262
Conversation
…eadme to include steps
…ocker, updated readme to include steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made some minor spelling corrections. Some things I noticed:
-
In the prerequisites it states a requirement for Docker, but this branch introduces the option for running without Docker. Should we update the language of that Prerequisites section?
-
Does the user need to do the .env initialization of the repo if you are running in Edge mode? The initial sections seem to require me to setup a full .env file, and a lot of that seems like optional stuff for my scenario of just wanting to run the head locally?
-
In the Initializing the repository section, it lists the new EdgeNoDocker environment variable but I don't see that in the .env.template? The instructions should also state what the accepted values are (TRUE/FALSE, YES/NO, 1/0). Is it even needed in the ENV if it's only used as a CLI param to the init script?
-
In the instructions for running the init.ps1 I noticed an inconsistency in variables.
-Edge_Token
and-EdgeNoDocker
. One has an underscore (_) and one does not. I think the new setting should be-Edge_NoDocker
, perhaps? -
Upon trying to execute the init script, I received a warning that I was not in administrator mode for PowerShell. This was obvious, once I thought about it, but before they run the init command we may want a 'warning' ⚠ to remind folks to get into Admin mode.
-
When running npm i on SUGCON EU folder, I got a warning that subscriptions-transport-ws is deprecated and should be replaced with graphql-ws.
-
When trying to run the SUGCON site on localhost:3000, I got an ERR_INVALID_URL. I'm guessing there is some sort of configuration I need to do in the ENV or on the init command, but no way for me to figure out what went wrong here.
Ok, I think i've got this improved now, addressing each of your points above in order....
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR automates the ability to configure this repository to run 'Edge Development mode with No Docker'. It adds a new param to
init.ps1
which will configure the heads, they can the be manually run directly on the host machine.The README has been updated to include steps required.
Types of changes
Checklist:
Closes #178