Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Administration & Public Contributions #294

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Review Administration & Public Contributions #294

merged 6 commits into from
Nov 29, 2023

Conversation

sc-ivanlieckens
Copy link
Collaborator

@sc-ivanlieckens sc-ivanlieckens commented Nov 21, 2023 •
edited
Loading

Description / Motivation

  • Add Filtering to Admin Applications Overview
  • Application Review Settings Admin UI
  • Added logging to general exceptions
  • Cleaned out old javascript
  • Attempt to stop strange exception in Remove Contribution
  • MVP Selections API Client to v4.9.0
  • Submitted MVP Step now supports markdown display of Eligibility and Objectives
  • Contributions can now be marked as Public during Application
  • Added ApplyContributionOverview view component
  • Adjusted Dashboard to have link to Contribution Overview
  • Adjusted some icons to align better across different overview actions
  • Application and Review timeframe are now shown as countdowns on Dashboard

@mrtamasvarga needs to be able to manage reviewers for applications

How Has This Been Tested?

Local Setup

Manual UI Testing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

@IvanLieckens
Add Filtering to Admin Applications Overview
efe0853 
+ MVP Selections API Client bumped to v4.5.1
@IvanLieckens
Application Review Settings
be8482a 
+ Added logging to general exceptions
+ Cleaned out old javascript
+ Attempt to stop strange exception in Remove Contribution
@sc-ivanlieckens sc-ivanlieckens added enhancement New feature or request MVP Site labels Nov 21, 2023
@IvanLieckens
Merge branch 'main' into feature/review-admin-improvements
4d54d9c
@IvanLieckens
Public Contributions and Improvements
6a5b3a1 
+ MVP Selections API Client to v4.9.0
+ Submitted MVP Step now supports markdown display of Eligibility and Objectives
+ Contributions can now be marked as Public during Application
+ Added ApplyContributionOverview view component
+ Adjusted Dashboard to have link to Contribution Overview
+ Adjusted some icons to align better across different overview actions
@sc-ivanlieckens sc-ivanlieckens changed the title Feature/review admin improvements Review Administration & Public Contributions Nov 27, 2023
@IvanLieckens
Dashboard Countdowns
4fee38c 
+ Application and Review timeframe are now shown as countdowns
@IvanLieckens
Missing items
ded3ac0
@sc-ivanlieckens sc-ivanlieckens merged commit 06f850c into main Nov 29, 2023
6 checks passed
@sc-ivanlieckens sc-ivanlieckens deleted the feature/review-admin-improvements branch November 29, 2023 09:29
@sc-ivanlieckens sc-ivanlieckens mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrtamasvarga mrtamasvarga mrtamasvarga approved these changes

Assignees

@robearlam robearlam

Labels
enhancement New feature or request MVP Site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sc-ivanlieckens @mrtamasvarga @robearlam @IvanLieckens