Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/155 create sitemap for mvp site #309

Conversation

navancommits
Copy link
Contributor

Generate Sitemap.xml for mvp site to aid SEO

Description / Motivation

Generates sitemap.xml for mvp site

So that mvp site betters in Google Search ranking

It is a new feature identified in issue list

How Has This Been Tested?

Tested against rendering host locally:
https://navansitecorenotes.blogspot.com/2023/12/how-to-build-sitemapxml-for-dotnet.html

Added settings in Sitecore CMS and ensured those pages appeared in Sitemap.xml

None, this is a stand-alone change and wouldn't affect existing MVP site functionality

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

@navancommits navancommits marked this pull request as draft December 22, 2023 02:15
@navancommits navancommits marked this pull request as ready for review December 22, 2023 02:53
@navancommits
Copy link
Contributor Author

Ready for review...

@robearlam
Copy link
Member

It looks like this is has been built and scratch and is not using the OOTB SiteMap generator provided by XMC.

As per #155 , we don't want a completely bespoke solution, it should be possible to leverage what already exists for the SUGCON sites / Headless SXA?

@robearlam
Copy link
Member

I'm going to close this now, instead of having it hang around. We can open a new one when we get the functionality built out against the SXA Headless features as described in #155

@robearlam robearlam closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants