Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logo Datasource and UI Improvements #385

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Logo Datasource and UI Improvements #385

merged 3 commits into from
Mar 4, 2024

Conversation

cheeto-bandito
Copy link
Contributor

Description / Motivation

  1. Setup the shared Header and Footer partial design Logo components to pull their datasources from query:$site/Data/Images/Logos/
  2. Copied the Image.tsx component and renamed to Logo.tsx
  3. Added the Storybook component (not tested)

How Has This Been Tested?

I've loaded up the partial designs and the SUGCONEU 2024 Homepage in Experience Editor to validate that the component renders as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

@lovesitecore lovesitecore merged commit ae84bb7 into Sitecore:main Mar 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesitecore lovesitecore lovesitecore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cheeto-bandito @lovesitecore