Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/78 error message #415

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Feature/78 error message #415

merged 2 commits into from
Mar 21, 2024

Conversation

ericsanner
Copy link
Contributor

Description / Motivation

https://trello.com/c/d5okF36d/78-create-404-error-page

image

How Has This Been Tested?

  1. Created Error Message component (did not create a variant of text/image)
  2. Tested on desktop, tablet, mobile
  3. Template accepts a title, description, and status code so it can be used for both 404 and 500 pages

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

@robearlam robearlam merged commit 34a496b into Sitecore:main Mar 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robearlam robearlam robearlam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericsanner @robearlam