Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed padding top and applied same component structure as Other Hero Variant #466

Merged
merged 1 commit into from
May 6, 2024

Conversation

lovesitecore
Copy link
Collaborator

The Event Variant of Hero Banner had a padding at the top. So I exchanged the markup with the one that has been fixed for the main variant and change background to black and font color to white.

Description / Motivation

see above

How Has This Been Tested?

tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

@robearlam robearlam merged commit abfc8c6 into main May 6, 2024
7 checks passed
@robearlam robearlam deleted the fix-hero-event-variant branch May 6, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants