Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Legacy SUGCON site assets from repo #469

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Remove Legacy SUGCON site assets from repo #469

merged 5 commits into from
Jun 26, 2024

Conversation

robearlam
Copy link
Member

With all of the SUGCON sites now being live against the new multi-site instance, we need to remove the old application elements.

Description / Motivation

Changes included in the PR

  • Removed legacy SUGCON sites codebases
  • Removed legacy SUGCON sites items
  • Configured all SUGCON sites to run from single container for local dev
  • Updated site definition items to include local dev hosts
  • Updated init, up & env vars for site host changes,
  • Moved API key into SUGCON 2024 serialised Items
  • Bumped Sitecore CLI version

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

@robearlam robearlam added enhancement New feature or request SUGCON Sites labels Jun 19, 2024
@robearlam robearlam marked this pull request as ready for review June 19, 2024 05:17
lovesitecore
lovesitecore reviewed Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@lovesitecore lovesitecore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the removed sugcon2024 ENV Variables. Other than that it looks good.

.env.template
@@ -14,8 +14,6 @@ SUGCON_INDIA_HOST_INTERNAL_URI=http://sugconindia:3000
SUGCON_NA_HOST=sugconna.xmcloudcm.localhost
SUGCON_NA_HOST_INTERNAL_URI=http://sugconna:3000
RENDERING_HOST_INTERNAL_URI=http://sugconanz:3000
SUGCON2024_EU_HOST=sugconeu2024.xmcloudcm.localhost
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the SUGCON 2024 Env Variables removed (also a bit down?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was because we had both SUGCON_EU_HOST and SUGCON2024_EU_HOST, where there is now only one EU site. I dropped the 2024 named version to align with the naming of the other SUGCON sites

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with the CDP related params as well.

@robearlam robearlam self-assigned this Jun 25, 2024
@robearlam robearlam merged commit c6f3d86 into main Jun 26, 2024
3 checks passed
@robearlam robearlam deleted the sugcon-cleanup branch June 26, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesitecore lovesitecore lovesitecore approved these changes

Assignees

@robearlam robearlam

Labels
enhancement New feature or request SUGCON Sites
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robearlam @lovesitecore