BlopStorage module variants added for 9.3.0 xm/xp topologies, includi… #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng basic xm docker-compose test azure blobstorage variant azure blobstorage variant sorted package names changelog.md update docs
anderslaub
requested review from
adoprog,
bplasmeijer and
jeanfrancoislarente
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Image Details
Pull Request Details
Adds a few simple xm and xp image variants with the Blobstorage module preinstalled.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
Just like finding the right icon for an item then the biggest challenge was to come up with a good short name for the blob-storage variant.
sitecore-bsalthough funny was disregarded for obvious reasons,sitecore-blobsounds really cool but a bit too long in comparison with other variants,sitecore-abssounds too much like plastic and azure is just default. I ended up going with the somewhat boring variant name-bl.I have just made a docker-compose test file for an xm topology, not xp.
If requested I already have 9.3.0 image variants defined for sxa-bl and jss-bl etc. that I can add along with additional test compose files. I did not add these now since this would in my opinion also call for a new module filter to be added in Build.ps1 - so rather than the current -IncludeX flags then an array of module variant names to include in the build.
Pre-submit Checklist
I have read and am familiar with the contents of CONTRIBUTING.md
I have built the images locally (all relevant OS versions, including Linux if applicable)
.\build.ps1command used (don't forget to exclude your credentials!)docker system prune -af)I have added or updated the necessary docker-compose file(s) in the
build/windows/testsfolderI have updated the documentation using
build\update-documentation.ps1I have updated the
build\CHANGELOG.mdwith details about the change(s) included