Skip to content

Commit

Permalink
[sitecore-jss] Set FETCH_WITH.REST to 'REST' instead of 'Rest' (#1927)
Browse files Browse the repository at this point in the history
* [sitecore-jss] Set FETCH_WITH.REST to 'REST' instead of 'Rest'

* Updated docs
  • Loading branch information
illiakovalenko authored Sep 12, 2024
1 parent 103e009 commit b9ecb63
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ Our versioning strategy is as follows:

### 🛠 Breaking Change

* `[sitecore-jss]` Set FETCH_WITH.REST to 'REST' instead of 'Rest' ([#1927](https://github.com/Sitecore/jss/pull/1927)):
* The `FETCH_WITH.REST` constant has been updated to 'REST' instead of 'Rest' to match the value that we mention in the documentation. If you are using this constant in your code, please update your FETCH_WITH env variable to 'REST'.
* `[templates/angular]` `[sitecore-jss-angular]` A new `JssStateService` has been introduced in the `sitecore-jss-angular` package, enhancing type safety and enabling state sharing across the application and SDK components. As a result, the JssContextService now relies on JssStateService for state management.([#1918](https://github.com/Sitecore/jss/pull/1918))
* `[sitecore-jss-proxy]` Updated exports of the module for better extensibility ([#1903](https://github.com/Sitecore/jss/pull/1903))
* `express@^4.19.2` dependency is marked as a peer dependency
Expand Down
2 changes: 2 additions & 0 deletions docs/upgrades/unreleased.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## Unreleased

* `FETCH_WITH.REST` constant string value from '@sitecore-jss/sitecore-jss' package now is set to 'REST' instead of 'Rest'. If you are using this constant in your code, please update your FETCH_WITH env variable to 'REST'.

# Angular

* Update the JssContextService and all the references to it, since some of the sitecore-jss-angular components now rely on the application state:
Expand Down
2 changes: 1 addition & 1 deletion packages/sitecore-jss/src/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export enum SitecoreTemplateId {

export const FETCH_WITH = {
GRAPHQL: 'GraphQL',
REST: 'Rest',
REST: 'REST',
};

export const JSS_MODE = {
Expand Down

0 comments on commit b9ecb63

Please sign in to comment.