Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-proxy] fix handling of HEAD requests when followRedirects is true #1627

Closed
wants to merge 2 commits into from

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Oct 9, 2023

Description / Motivation

Customers have reported that having an app hosted inside a jss ssr proxy and 'followRedirects' is set to 'true' - HEAD requests fail. This PR addresses the issue by handling the different types of proxy request objects in the two scenarios.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko
Copy link
Contributor

@yavorsk Please, fill the details and update the CHANGELOG

@yavorsk
Copy link
Contributor Author

yavorsk commented Oct 13, 2023

Issue resolved with PR#1630 therefore closing this one.

@yavorsk yavorsk closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants