Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#600951: [templates/nextjs] fixed plugin of cors header #1637

Merged
merged 5 commits into from
Oct 26, 2023
Merged

#600951: [templates/nextjs] fixed plugin of cors header #1637

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
376d8b8
#600951: [templates/nextjs] fixed plugin of cors header
sc-ruslanmatkovskyi Oct 25, 2023
c1c5f9f
#600951: changed CHANGELOG
sc-ruslanmatkovskyi Oct 25, 2023
158ff8a
#600951: fixed styling of code
sc-ruslanmatkovskyi Oct 25, 2023
f91ac22
#600951: reverted fixed styling code
sc-ruslanmatkovskyi Oct 25, 2023
7c2e13b
#600951: refactoring extend headers
sc-ruslanmatkovskyi Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Our versioning strategy is as follows:
* `[templates/nextjs]` Enable client-only BYOC component imports. Client-only components can be imported through src/byoc/index.client.ts. Hybrid (server render with client hydration) components can be imported through src/byoc/index.hybrid.ts. BYOC scaffold logic is also moved from nextjs-sxa addon into base template ([#1628](https://github.com/Sitecore/jss/pull/1628)[#1636](https://github.com/Sitecore/jss/pull/1636))
* `[templates/nextjs]` Import SitecoreForm component into sample nextjs app ([#1628](https://github.com/Sitecore/jss/pull/1628))
* `[sitecore-jss-nextjs]` (Vercel/Sitecore) Deployment Protection Bypass support for editing integration. ([#1634](https://github.com/Sitecore/jss/pull/1634))
* `[templates/nextjs]` Fix custom headers. Now in cors-header plugin extends custom headers from next.config.js file. ([#1637](https://github.com/Sitecore/jss/pull/1637))

### 🐛 Bug Fixes

Expand Down
1 change: 1 addition & 0 deletions packages/create-sitecore-jss/src/templates/nextjs/src/lib/next-config/plugins/cors-header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const corsHeaderPlugin = (nextConfig = {}) => {
return Object.assign({}, nextConfig, {
async headers() {
return [
...await nextConfig?.headers(),
ambrauer marked this conversation as resolved.
Show resolved Hide resolved
{
source: '/_next/:path*',
headers: [{ key: 'Access-Control-Allow-Origin', value: config.sitecoreApiHost }],
Expand Down