Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next.js] JSS Edge Proxy and Context Support #1640

Merged
merged 10 commits into from
Oct 27, 2023
Merged

[Next.js] JSS Edge Proxy and Context Support #1640

merged 10 commits into from
Oct 27, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Oct 26, 2023 •
edited
Loading

Description / Motivation

This PR introduces Sitecore Edge Platform and Context support:

  • Introducing the clientFactory property. This property can be utilized by GraphQL-based services, the previously used endpoint and apiKey properties are deprecated. The clientFactory serves as the central hub for executing GraphQL requests within the application.
  • New SITECORE_EDGE_CONTEXT_ID environment variable has been added.
  • The JSS_APP_NAME environment variable has been updated and is now referred to as SITE_NAME.
  • All graphQL-based services now are using clientFactory instead of apiKey, endpoint properties.

Testing Details

  • Unit Test Added
    Introduced at least 1 unit test to cover clientFactory for each graphQL-based service. I didn't duplicate all the existing tests, since functionality is the same. Let's transfer all the tests once we remove endpoint and apiKey properties.
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team October 26, 2023 11:38
ambrauer
ambrauer suggested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! See (mostly minor) suggestions and reminders for things we already discussed.

packages/create-sitecore-jss/src/templates/nextjs/.env Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/.env Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/.env Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/scripts/config/plugins/fallback.ts Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/scripts/generate-config.ts Outdated Show resolved Hide resolved
packages/sitecore-jss/src/graphql-request-client.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-nextjs/src/index.ts Show resolved Hide resolved
packages/sitecore-jss/src/graphql/graphql-edge-proxy.ts Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/src/lib/graphql-client-factory/utils.ts Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-multisite/scripts/config/plugins/multisite.ts Show resolved Hide resolved
ambrauer
ambrauer approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 last suggestions, otherwise approved 👍

packages/create-sitecore-jss/src/templates/nextjs/.env Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-multisite/scripts/config/plugins/multisite.ts Show resolved Hide resolved
@illiakovalenko illiakovalenko merged commit ca076b1 into dev Oct 27, 2023
1 check passed
@illiakovalenko illiakovalenko deleted the feature/JSS-527 branch October 27, 2023 12:57
@ambrauer ambrauer mentioned this pull request Nov 21, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer