[RAV][node-ssr] Update samples to use SITE_NAME instead of JSS_APP_NAME #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorsk
requested review from
art-alexeyenko,
illiakovalenko and
addy-pathania
art-alexeyenko
requested changes
Nov 2, 2023
packages/create-sitecore-jss/src/templates/react/scripts/generate-config.js
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/vue/scripts/generate-config.js
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/angular/scripts/generate-config.ts
Outdated
Show resolved
Hide resolved
art-alexeyenko
approved these changes
Nov 3, 2023
packages/create-sitecore-jss/src/templates/react/scripts/generate-config.js
Outdated
Show resolved
Hide resolved
yavorsk
added a commit
that referenced
this pull request
Nov 7, 2023
[RAV][node-ssr] Update samples to use SITE_NAME instead of JSS_APP_NAME
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Switch from using JSS_APP_NAME to SITE_NAME - this PR includes renaming all environment/config variables in React, Vue, Angular templates as well as ssr node proxy app templates.
Testing Details
Types of changes