Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss] Fix FEAAS stylesheet issue #1651

Merged
merged 2 commits into from
Nov 2, 2023
Merged

[sitecore-jss] Fix FEAAS stylesheet issue #1651

merged 2 commits into from
Nov 2, 2023

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Nov 2, 2023 •
edited
Loading

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team November 2, 2023 13:41
@addy-pathania addy-pathania changed the title [sitecore-jss] Fix CSS styles issue [sitecore-jss] Fix FEAAS stylesheet issue Nov 2, 2023
art-alexeyenko
art-alexeyenko reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think themes.test should also be updated - we check for rel: 'style' in there, should be 'stylesheet' in tests too.

@addy-pathania addy-pathania merged commit 1412b67 into dev Nov 2, 2023
1 check passed
@addy-pathania addy-pathania deleted the bug/jss-1027-stylesheet branch November 2, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addy-pathania @art-alexeyenko