-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nextjs] CloudSDK Integration #1652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illiakovalenko
changed the title
[DRAFT] Engage SDK integration
[Nextjs] CloudSDK Integration
Nov 6, 2023
…emplate (driven by prompt / --xmcloud CLI option)
…(GraphQLSiteInfoService)
ambrauer
reviewed
Nov 7, 2023
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/package.json
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/byoc/index.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/lib/context/index.ts
Outdated
Show resolved
Hide resolved
...s/create-sitecore-jss/src/templates/nextjs-xmcloud/src/lib/middleware/plugins/personalize.ts
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/personalize-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/personalize-middleware.ts
Outdated
Show resolved
Hide resolved
ambrauer
reviewed
Nov 8, 2023
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/lib/context/index.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/lib/context/index.ts
Outdated
Show resolved
Hide resolved
ambrauer
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍
art-alexeyenko
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Initial commit * Handle async Events init call * Update * Update * Updated test * rename nextjs-personalize -> nextjs-xmcloud. move feaas and BYOC here. * Move Sitecore Edge Platform / conext related items to nextjs-xmcloud * Updated context initialization * Updated dependency * Updated Yarn.lock * Fix lint errors * Updated CHANGELOG * Repurpose nextjs-personalize -> nextjs-xmcloud initializer "system" template (driven by prompt / --xmcloud CLI option) * Moved skipping of site information fetch on XM Cloud to base package (GraphQLSiteInfoService) * CHANGELOG update * Updated Context implementation, added unit tests * Updated CHANGELOG * Updated comment * Updated cloudsdk to use latest production version * Updated yarn.lock * Introduced Bootstrap and pulled nextjs-xmcloud * Update .env * Updated jsdoc * Avoid unused vars rule for Bootstrap * Normalize sitecoreEdgeUrl * Updated CHANGELOG * Updated BYOC initialization * Updated Props doc * Updates * Updated unit test * Updated comment * Provided sitecoreEdgeUrl to the middleware * Refactoring * Passing props to SDK's * Updated type * Renamed SDKs -> sdks * Updated yarn.lock --------- Co-authored-by: Adam Brauer <[email protected]> (cherry picked from commit 6325950)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This pull request introduces CloudSDK integration into our codebase, enabling several enhancements and improvements.
The new npm packages are: @sitecore-cloudsdk/events, @sitecore-cloudsdk/personalize
The main changes in this PR are as follows:
Testing Details
Types of changes