Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next.js] Fixes for nextjs-xmcloud Initializer Template #1657

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

ambrauer
Copy link
Contributor

@ambrauer ambrauer commented Nov 8, 2023

Description / Motivation

Follow-up to #1653 which fixes the following issues:

  • Fix issue where nextjs-xmcloud template's /src/lib/next-config/plugins/monorepo.js wasn't being cleaned up properly. Use dedicated monorepo-xmcloud.js instead.
  • Fix issue with init-runner where response.initializers would prevent any following initializers to be skipped (return statement caused early exit)

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

…s/monorepo.js wasn't being cleaned up properly. Use dedicated monorepo-xmcloud.js instead.
…any following initializers to be skipped (return statement caused early exit)
@ambrauer ambrauer merged commit b691251 into dev Nov 8, 2023
1 check passed
@ambrauer ambrauer deleted the fix/JSS-1117-nextjs-xmcloud-template branch November 8, 2023 00:50
art-alexeyenko pushed a commit that referenced this pull request Nov 8, 2023
* Fix issue where nextjs-xmcloud template's /src/lib/next-config/plugins/monorepo.js wasn't being cleaned up properly. Use dedicated monorepo-xmcloud.js instead.

* Fix issue with init-runner where response.initializers would prevent any following initializers to be skipped (return statement caused early exit)

* updated CHANGELOG

(cherry picked from commit b691251)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant