Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-headless-ssr-proxy] Add sc_site qs parameter to Layout Service requests by default #1660

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Nov 13, 2023

Description / Motivation

The sc_site query string parameter is now added to Layout Service requests by default. This is to ensure that the Layout Service request is routed to the correct Sitecore site when using the proxy. It ensures that the target site is resolved correctly for both Layout and Dictionary Service requests (For Dictionary Service requests, the sc_site parameter is already added to the request path, see config.ts, path).

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko changed the title [node-headless-ssr-proxy] Add sc_site qs parameter to Layout Service requests by defauilt [node-headless-ssr-proxy] Add sc_site qs parameter to Layout Service requests by default Nov 13, 2023
@illiakovalenko illiakovalenko requested a review from a team November 13, 2023 14:00
@yavorsk yavorsk merged commit a17621a into dev Nov 22, 2023
1 check passed
@yavorsk yavorsk deleted the bugfix/JSS-884 branch November 22, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants