Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nextjs] [Context] Context's getSDK is non-enumerable #1662

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Nov 13, 2023

Description / Motivation

In case we are trying to merge context instance as an object we lose all available methods, e.g getSDK.
This PR changes getSDK to use arrow function, in this case it's available after the merge operation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko merged commit 73375ef into dev Nov 13, 2023
1 check was pending
@illiakovalenko illiakovalenko deleted the bugfix/JSS-1188 branch November 13, 2023 21:51
illiakovalenko added a commit that referenced this pull request Nov 13, 2023
* [Nextjs] [Context] Context's getSDK is non-enumerable

* Updated CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant