[sitecore-jss-nextjs] Reject SDK promise when init was rejected #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrauer
reviewed
Jan 11, 2024
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/lib/context/sdk/events.ts
Outdated
Show resolved
Hide resolved
ambrauer
approved these changes
Jan 12, 2024
7 tasks
addy-pathania
pushed a commit
that referenced
this pull request
Jan 17, 2024
[sitecore-jss-nextjs] Reject getSDK promise when SDK init was rejected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Events SDK should not initialize in dev environment or server context. This PR ensures Events SDK promise is not pending in such situations and will reject instead. Context logic has been made to handle initialization rejects.
Testing Details
Types of changes