Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs]: #60701 the redirects middleware has been fixed when there is using absolute url in target #1727

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented Feb 6, 2024

The redirects middleware has been fixed when there is using absolute url in target

Description / Motivation

The site language context was used in target of absolute url which was wrong

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugfix/607601-redirect-absolute-url branch from 402d1ee to 5b89534 Compare February 6, 2024 22:11
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugfix/607601-redirect-absolute-url branch from 5b89534 to df91a99 Compare February 6, 2024 22:13
@illiakovalenko illiakovalenko merged commit 02ab317 into dev Feb 7, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the bugfix/607601-redirect-absolute-url branch February 7, 2024 10:31
@illiakovalenko illiakovalenko changed the title [sitecore-jss-nextjs]: #60701 the redirects middleware has been fixe… [sitecore-jss-nextjs]: #60701 the redirects middleware has been fixed when there is using absolute url in target Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants