Introduce a DateField type and rename Date component for consistency. #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a DateField type and rename Date component to follow the naming pattern used by all other JSS field components. Compare Date.tsx to Text.tsx, Image.tsx, Link.tsx, File.tsx, or RichText.tsx. The naming of the Date component is inconsistent with the other field components and it is missing the interface/type like the others have.
illiakovalenko
added
the
backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a DateField type and rename Date component to follow the naming pattern used by all other JSS field components.
Description / Motivation
Compare Date.tsx to Text.tsx, Image.tsx, Link.tsx, File.tsx, or RichText.tsx. The naming of the Date component is inconsistent with the other field components and it is missing the interface/type like the others have. Ensuring consistency in naming improves the code readability and can reduce issues when developing new components, improving the developer experience.
Testing Details
Types of changes