Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[template/nextjs] Fix personalize and feaas module not found error #1760

Closed
wants to merge 2 commits into from

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Mar 15, 2024

Description / Motivation

For some unknown reason, the dependencies @sitecore-feaas/clientside and @sitecore-cloudsdk/personalize, which are listed as peerDependencies in @sitecore-jss/sitecore-jss-nextjs, are not being installed for some users. This is a workaround for this issue.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team March 15, 2024 21:12
@thezaff
Copy link

thezaff commented Mar 18, 2024

I've been using --force flag to install dependencies without this issue for a week now :)

Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case do we need the reference to @sitecore-feaas/clientside in the xmcloud add on?

@illiakovalenko
Copy link
Contributor

@sc-addypathania Did you explore any other options? Is this problem related to Node.js version? And may be we can execute "npm install" with additional flags to workaround that?
Shortly, we shouldn't include any dependencies in a base template that are not used there

@addy-pathania
Copy link
Contributor Author

addy-pathania commented Mar 18, 2024

So this issue is being caused by the legacy-peer-deps flag being set to true in one of the .npmrc files.
After setting it to false all the peer dependencies are installed fine.
Will add a bit more details to the open issue here
Closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants