[templates/nextjs-sxa] Background image in Container component has been changed #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc-ruslanmatkovskyi
changed the title
packages/create-sitecore-jss/src/templates/nextjs-sxa/src/components/Container.tsx
Outdated
Show resolved
Hide resolved
…-background-image-container-component
illiakovalenko
deleted the
bugfix/fix-background-image-container-component
branch
illiakovalenko
pushed a commit
that referenced
this pull request
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
The background image in the Container component was being generated from the image ID instead of the mediaUrl parameter. This fix changes that behavior.
Testing Details
Types of changes