[angular-xmcloud] Introduce column-splitter component for angular #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illiakovalenko
requested changes
Aug 14, 2024
There was a problem hiding this comment.
See two notes:
- Please, make sure to verify your changes before opening the PR, since the component is not rendered as expected (I tested locally). I created a bug in our dashboard
- Yes - we are reusing (copying) SXA's components functionality from Next.js. But if we have some room for improvement or ways how to make it more prettier it should be applied
...rc/templates/angular-xmcloud/src/app/components/column-splitter/column-splitter.component.ts
Outdated
Show resolved
Hide resolved
...rc/templates/angular-xmcloud/src/app/components/column-splitter/column-splitter.component.ts
Outdated
Show resolved
Hide resolved
...rc/templates/angular-xmcloud/src/app/components/column-splitter/column-splitter.component.ts
Outdated
Show resolved
Hide resolved
.../templates/angular-xmcloud/src/app/components/column-splitter/column-splitter.component.html
Outdated
Show resolved
Hide resolved
.../templates/angular-xmcloud/src/app/components/column-splitter/column-splitter.component.html
Outdated
Show resolved
Hide resolved
.../templates/angular-xmcloud/src/app/components/column-splitter/column-splitter.component.html
Outdated
Show resolved
Hide resolved
.../templates/angular-xmcloud/src/app/components/column-splitter/column-splitter.component.html
Outdated
Show resolved
Hide resolved
.../templates/angular-xmcloud/src/app/components/column-splitter/column-splitter.component.html
Outdated
Show resolved
Hide resolved
.../templates/angular-xmcloud/src/app/components/column-splitter/column-splitter.component.html
Outdated
Show resolved
Hide resolved
art-alexeyenko
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Add
ColumnSplitterComponentto angular xmcloudTesting Details
Types of changes