Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[template/angular-xmcloud] Introduce SXA PageContent component #1892

Closed
wants to merge 6 commits into from
Closed

[template/angular-xmcloud] Introduce SXA PageContent component #1892

wants to merge 6 commits into from

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Aug 16, 2024 •
edited
Loading

Description / Motivation

Add SXA PageContent component to angular-xmcloud

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko force-pushed the dev branch 2 times, most recently from 99c9982 to e104237 Compare August 19, 2024 07:19
yavorsk
yavorsk approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@yavorsk yavorsk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

...ss/src/templates/angular-xmcloud/src/app/components/page-content/page-content.component.html Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavorsk yavorsk yavorsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addy-pathania @yavorsk @apathania22