[Angular][XMC] Ensure context is available at the time of placeholder rendering #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illiakovalenko
approved these changes
Oct 11, 2024
yavorsk
reviewed
Oct 11, 2024
packages/sitecore-jss-angular/src/components/placeholder.component.spec.ts
Outdated
Show resolved
Hide resolved
…21-container-placeholder # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
ngOnChanges executes before ngOnInit within placeholder component. This is expected (but not obvious).
Considering we need metadataMode value to be available already, the context subscription is moved to constructor (can't use it in OnChanges as it's called multiple times).
Testing Details
Types of changes