-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[angular][xmcloud] CDP page view component #1957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Please, review my comments below
...itecore-jss/src/templates/angular-xmcloud/src/app/routing/scripts/cdp-page-view.component.ts
Outdated
Show resolved
Hide resolved
...itecore-jss/src/templates/angular-xmcloud/src/app/routing/scripts/cdp-page-view.component.ts
Outdated
Show resolved
Hide resolved
...itecore-jss/src/templates/angular-xmcloud/src/app/routing/scripts/cdp-page-view.component.ts
Outdated
Show resolved
Hide resolved
...tecore-jss/src/templates/angular-xmcloud/src/app/routing/scripts/cloud-sdk-init.component.ts
Outdated
Show resolved
Hide resolved
...itecore-jss/src/templates/angular-xmcloud/src/app/routing/scripts/cdp-page-view.component.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed few other things, please, take a look below
CHANGELOG.md
Outdated
* `[angular-xmcloud]``[sitecore-jss-angular]` Analytics and CloudSDK integration | ||
* `[angular-xmcloud]` Add CloudSDK initialization on client side ([#1952](https://github.com/Sitecore/jss/pull/1952)) | ||
* `[angular-xmcloud]` Add CloudSDK initialization on client side ([#1952](https://github.com/Sitecore/jss/pull/1952)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one requires migration guide as well. You can ping @art-alexeyenko to add it
packages/create-sitecore-jss/src/templates/angular-xmcloud/.env
Outdated
Show resolved
Hide resolved
Co-authored-by: Illia Kovalenko <[email protected]>
…to feature/jss-3977
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description / Motivation
Introduces CDP page view component to angular xmc app and add it to the app's scripts component by default.
It fires pageView event only in normal mode.
Testing Details
Types of changes