Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates/angular-xmcloud] [templates/node-xmcloud-proxy] Update angular xmcloud and xmcloud proxy readme's #1985

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Nov 27, 2024

Description / Motivation

This PR updates the readme files of the angular xmcloud and node xmcloud proxy templates according to the latest discussions and the updates in the xmcloud foundation starter kit.

  • reword pages integration
  • production and connected mode instruction updates for angular-xmcloud

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@yavorsk yavorsk requested a review from a team November 27, 2024 14:23
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@addy-pathania addy-pathania merged commit 991c8f5 into dev Nov 28, 2024
2 checks passed
@addy-pathania addy-pathania deleted the feature/JSS-4595 branch November 28, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants