Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates/nextjs-sxa]: The imports of font-awesome has been fixed #SXA-7659 #1998

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented Dec 10, 2024

Description / Motivation

The font-awesome package imports (e.g., @fontawesome/) were failing in the custom workspace due to incorrect paths or missing dependencies.

Corrected SCSS imports by explicitly specifying the proper path (~font-awesome/scss/...) in SCSS files.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@yavorsk yavorsk merged commit 4a0927f into dev Dec 12, 2024
1 check passed
@yavorsk yavorsk deleted the bugfix/SXA-7659-font-awesome-import branch December 12, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants