Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-nextjs]: Updated logic to properly handle cases like [/]? #SXA-6320 #1999

Merged
merged 2 commits into from
Dec 16, 2024
Merged

[sitecore-jss-nextjs]: Updated logic to properly handle cases like [/]? #SXA-6320 #1999

merged 2 commits into from
Dec 16, 2024

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented Dec 10, 2024 •
edited
Loading

Description / Motivation

Testing Details

Updated logic to properly handle cases like [/]? and prevent unnecessary escaping of valid regex operators.

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

yavorsk
yavorsk approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yavorsk yavorsk merged commit 20c3932 into dev Dec 16, 2024
1 check passed
@yavorsk yavorsk deleted the bugfix/SXA-6320-redirects branch December 16, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavorsk yavorsk yavorsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc-ruslanmatkovskyi @yavorsk