Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss] Fix undefined fields from event overriding layout data #2002

Merged
merged 2 commits into from
Dec 17, 2024
Merged

[sitecore-jss] Fix undefined fields from event overriding layout data #2002

merged 2 commits into from
Dec 17, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Dec 16, 2024 •
edited
Loading

Description / Motivation

Fix for Component Library. Prevents 'undefined' fields from an update event overriding existing layout data fields.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team December 16, 2024 19:34
addy-pathania
addy-pathania approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@art-alexeyenko art-alexeyenko merged commit 32e43ce into dev Dec 17, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the bug/jss-4556-undefined-fields branch December 17, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addy-pathania addy-pathania addy-pathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @addy-pathania