Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-nextjs] Remove variantId from query in Comp Library #2005

Merged
merged 3 commits into from
Dec 23, 2024
Merged

[sitecore-jss-nextjs] Remove variantId from query in Comp Library #2005

merged 3 commits into from
Dec 23, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Dec 18, 2024 •
edited
Loading

Description / Motivation

variantID is no longer required to come from JSS side by Component Library.

Testing Details

  • Unit Test Adjusted
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team December 18, 2024 14:06
illiakovalenko
illiakovalenko requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove variantId from component service as well

illiakovalenko
illiakovalenko approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@art-alexeyenko art-alexeyenko merged commit 7ddd22d into dev Dec 23, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the feature/JSS-4556-remove-variantid branch December 23, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @illiakovalenko