Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConditionSettings definition to ViewModel #545

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

st3mc5
Copy link

@st3mc5 st3mc5 commented Feb 2, 2021

Add in the missing conditionSettings field to the jss-forms ViewModel.

Description

The JSS forms package is the condition settings data model, this force using any or extending typings when implementing any conditions based field code.
This PR adds the additional data that Sitecore returns in the JSON payload.

Motivation

Allows users of this package to create type-safe implementations of field conditions.

How Has This Been Tested?

This PR adds typings only so shouldn't affect user code adversely unless someone has added typings into their code.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (non-breaking change; modified files are limited to the /docs directory)

Checklist:

  • I have read the Contributing guide.
  • My code follows the code style of this project.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change and it requires an update to the documentation.
  • My change is a documentation change and it requires an update to the navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants