Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExprPotionEffect - bring parity with EffPotion #7423

Closed

Conversation

ShaneBeee
Copy link
Contributor

Description

This PR aims to bring some parity between ExprPotionEffect and EffPotion.

Changes:

  • added the option to make an infinite potion effect
  • added the option to hide the icon
  • a little bit of syntax cleanup

Target Minecraft Versions: any
Requirements: none
Related Issues: none

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Romitou Romitou added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 12, 2025
@APickledWalrus APickledWalrus self-requested a review January 12, 2025 16:48
ShaneBeee and others added 2 commits January 12, 2025 08:56
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
@ShaneBeee
Copy link
Contributor Author

Got approved, but didnt make it in 😔

@ShaneBeee ShaneBeee closed this Jan 16, 2025
@ShaneBeee ShaneBeee deleted the shane/potion-effect-upgrades branch January 16, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants