Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExprWeather + ExprPlayerWeather Merge #7442

Open
wants to merge 2 commits into
base: dev/feature
Choose a base branch
from
Open

ExprWeather + ExprPlayerWeather Merge #7442

wants to merge 2 commits into from

Conversation

TheAbsolutionism
Copy link
Contributor

Description

This PR aims to merge ExprPlayerWeather into ExprWeather to resolve conflicts between the 2 expressions.

Target Minecraft Versions: any
Requirements: none
Related Issues: #6765

@UnderscoreTud UnderscoreTud added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 15, 2025
UnderscoreTud
UnderscoreTud requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@UnderscoreTud UnderscoreTud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests utilizing the different weather events?

src/main/java/ch/njol/skript/expressions/ExprWeather.java
Comment on lines +40 to +41
"[the] [custom|client] weather [(in|of) %worlds/players%]",
"%worlds/players%'[s] [custom|client] weather");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client weather of %world% doesn't make sense. It might be better to make custom and client exclusive to player weathers.

@TheLimeGlass
Copy link
Collaborator

TheLimeGlass commented Jan 15, 2025 •
edited
Loading

Can you add tests utilizing the different weather events?

Might not be possible if the event isn't fired until the next tick. Unless wanting to make a whole JUnit for it.

@Efnilite
Copy link
Member

Can you add tests utilizing the different weather events?

Might not be possible if the event isn't fired until the next tick.

junit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnderscoreTud UnderscoreTud UnderscoreTud requested changes

@TheLimeGlass TheLimeGlass TheLimeGlass requested changes

@Efnilite Efnilite Efnilite approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheAbsolutionism @TheLimeGlass @Efnilite @UnderscoreTud