Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable logging config #581

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

lu-xiaoshuang
Copy link
Contributor

  • Why submit this pull request?
    New feature provided

configurationBuilder.AddJsonFile("skyapm." + environment + ".json", true);
IConfiguration configuration = configurationBuilder.Build();
string enable = configuration?.GetSection("SkyWalking:Enable").Value ?? "false";
if (null == enable || !"true".Equals(enable.ToLower()))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable/disable skywalking agent by config file

{
return services;
}
string serviceName = configuration?.GetSection("SkyWalking:ServiceName").Value ?? "";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get service name from config file instead of environment variable (for windows services)

@liuhaoyang liuhaoyang merged commit 495d3c5 into SkyAPM:main Mar 26, 2024
2 checks passed
@lu-xiaoshuang lu-xiaoshuang deleted the logging-config branch March 27, 2024 01:35
@sampsonye sampsonye mentioned this pull request Apr 29, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants