Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Dungeon Flow Events: #36

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added Dungeon Flow Events: #36

wants to merge 3 commits into from

Conversation

yourboykyle
Copy link

  • Enter dungeon
  • Dungeon started
  • Dungeon ended
  • Left dungeon
  • Wither key obtained
  • Wither door opened
  • Blood key obtained
  • Blood door opened
  • Entered boss fight

Added Dungeon Flow Events:
6481634 
- Enter dungeon
- Dungeon started
- Dungeon ended
- Left dungeon
- Wither key obtained
- Wither door opened
- Blood key obtained
- Blood door opened
- Entered boss fight
@yourboykyle yourboykyle mentioned this pull request Oct 4, 2023
Closed
UnexDev
UnexDev reviewed Oct 4, 2023
View reviewed changes
Copy link

@UnexDev UnexDev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple concerns:

Why is all of the functionality inside a "Util" class?
Code is a bit messy, and you rewrote things that are not related to this PR.

If I could propose code changes, I would probably move functionality out of a "Util" class so that we don't dive into util hell. I would also revert some of the formatting and placement changes so that the commit history is not a bunch of refactoring.

Refer to my other review below:

UnexDev
UnexDev reviewed Oct 4, 2023
View reviewed changes
Copy link

@UnexDev UnexDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review specific things I commented and reply with your thoughts / feedback.

src/main/java/io/github/skyblockcore/mixin/MessageHandlerMixin.java Outdated Show resolved Hide resolved
src/main/java/io/github/skyblockcore/SkyBlockCore.java Show resolved Hide resolved
src/main/java/io/github/skyblockcore/util/DungeonUtils.java Outdated Show resolved Hide resolved
src/main/java/io/github/skyblockcore/event/dungeons/EnteredBossfightCallback.java Outdated Show resolved Hide resolved
src/main/java/io/github/skyblockcore/event/dungeons/DungeonEndedCallback.java Outdated Show resolved Hide resolved
src/main/java/io/github/skyblockcore/event/dungeons/DungeonStartedCallback.java Outdated Show resolved Hide resolved
@yourboykyle
Copy link
Author

I have a couple concerns:

Why is all of the functionality inside a "Util" class? Code is a bit messy, and you rewrote things that are not related to this PR.

If I could propose code changes, I would probably move functionality out of a "Util" class so that we don't dive into util hell. I would also revert some of the formatting and placement changes so that the commit history is not a bunch of refactoring.

Refer to my other review below:

Do the formatting and placement changes really matter? It was triggering my OCD very much.

Reviewed the changes suggested by Unex:
e729f0b 
- Changed "if(!isInDungeon()) return;" to be "if(isInDungeon()) {...}"
- Moved DungeonUtils to io.github.skyblockcore.dungeons
- Added name of boss to EnteredBossfightCallback
- Added score to DungeonEndedCallback
- Added the class (Healer, Mage, Berserk, Archer, Tank) to DungeonStartedCallback
Ascynx
Ascynx previously approved these changes Oct 4, 2023
View reviewed changes
@UnexDev
Copy link

UnexDev commented Oct 4, 2023 •
edited
Loading

I have a couple concerns:

Why is all of the functionality inside a "Util" class? Code is a bit messy, and you rewrote things that are not related to this PR.

If I could propose code changes, I would probably move functionality out of a "Util" class so that we don't dive into util hell. I would also revert some of the formatting and placement changes so that the commit history is not a bunch of refactoring.

Refer to my other review below:

Do the formatting and placement changes really matter? It was triggering my OCD very much.

I really appreciate the time and effort, however I have one little issue:
There is still a "DungeonUtils" class. Can you move it to io.github.skyblockcore.Dungeons?

If I could propose edits I would :/

@yourboykyle
Copy link
Author

I have a couple concerns:

Why is all of the functionality inside a "Util" class? Code is a bit messy, and you rewrote things that are not related to this PR.

If I could propose code changes, I would probably move functionality out of a "Util" class so that we don't dive into util hell. I would also revert some of the formatting and placement changes so that the commit history is not a bunch of refactoring.

Refer to my other review below:

Do the formatting and placement changes really matter? It was triggering my OCD very much.

I really appreciate the time and effort, however I have one little issue: There is still a "DungeonUtils" class. Can you move it to io.github.skyblockcore.Dungeons?

If I could propose edits I would :/

Done. Will commit in the morning.

Moved io.github.skyblockcore.dungeons.DungeonUtils to io.github.skybl…
13787e4 
…ockcore.Dungeons, as per Unex's suggestion.
@yourboykyle
Copy link
Author

Pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnexDev UnexDev UnexDev left review comments

@Ascynx Ascynx Ascynx approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yourboykyle @UnexDev @Ascynx