Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create_prs): check whether PR description file has been updated #145

Merged
merged 7 commits into from
Aug 26, 2024

Conversation

Dan7-7-7
Copy link
Collaborator

@Dan7-7-7 Dan7-7-7 commented Aug 14, 2024

To deal with #124

Also adds a missing test for creating PRs with custom description file.

Replacing #130 which was unnecessarily complicated. Checking the title and body TODOs, which definitely should not be wanted by the user, should achieve the same thing.

The only downside of this is that if we change the template, we'll have to change strings in a couple of other places as well. But this will happen very rarely and will be easy to notice.

Copy link
Collaborator

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - much simpler!

@Dan7-7-7 Dan7-7-7 merged commit 55ca75f into main Aug 26, 2024
5 checks passed
@Dan7-7-7 Dan7-7-7 deleted the catch_readme_unchanged branch August 26, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants