Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix: show orphaned student tasks #520

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

nbey
Copy link
Contributor

@nbey nbey commented Mar 19, 2020

This PR aims to resolve an issue where student tasks that have a parent task that is not currently being included in the tasks store are not being shown.

  • show orphaned student tasks
  • sort tasks by due date, title ascending (client-side)
  • redundant server-side sort
  • create cypress test case

- improve nomenclature
@nbey nbey changed the title fix: show orphaned student tasks WIP: fix: show orphaned student tasks Mar 24, 2020
@themightychris
Copy link
Contributor

@nbey ping me on slack when this is ready for final review/merge

@themightychris
Copy link
Contributor

themightychris commented Apr 21, 2020

@nbey did we merge this in another PR already?

@nbey
Copy link
Contributor Author

nbey commented Apr 26, 2020

Nope -- I ran into some issues with getting the server-side sorting to fall-back and replicate the front-end. Also, I think I still need to create a cypress test case for this.

@themightychris themightychris marked this pull request as draft December 8, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants