Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ratings): support arbitrary weights for skill ratings [SCHOOL-24] #574

Open
wants to merge 165 commits into
base: develop
Choose a base branch
from
Open

feat(ratings): support arbitrary weights for skill ratings [SCHOOL-24] #574

wants to merge 165 commits into from

Conversation

nbey
Copy link
Contributor

@nbey nbey commented Feb 2, 2021 •
edited by themightychris
Loading

Closes: SCHOOL-24

  • feat: create migrations for new ratings
    • create EvidenceWeight column
    • migrate records to use EvidenceWeight
    • deprecate Override column
  • feat: re-implement ability to create Override demonstrations
    • chore: remove deprecated field
    • fix: demonstration skill validation logic
    • fix: SlateDemonstrationsTeacher app Override creation

@github-actions github-actions bot temporarily deployed to pr-574 February 2, 2021 21:36 Destroyed
@github-actions github-actions bot temporarily deployed to pr-574 February 3, 2021 01:29 Destroyed
@github-actions github-actions bot temporarily deployed to pr-574 February 3, 2021 02:57 Destroyed
@github-actions github-actions bot temporarily deployed to pr-574 February 15, 2021 15:27 Destroyed
@github-actions github-actions bot temporarily deployed to pr-574 March 28, 2021 19:06 Destroyed
@github-actions github-actions bot temporarily deployed to pr-574 March 28, 2021 19:06 Destroyed
@themightychris themightychris changed the base branch from develop to features/new-ratings-slider March 28, 2021 22:30
@themightychris themightychris force-pushed the features/new-ratings-slider branch 2 times, most recently from 6b7303c to 9c5202e Compare March 30, 2021 17:50
@nbey nbey force-pushed the features/new-ratings-slider branch from 9c5202e to c1e624d Compare April 7, 2021 17:58
@themightychris themightychris marked this pull request as draft June 8, 2021 17:43
@themightychris themightychris changed the base branch from features/new-ratings-slider to develop August 21, 2022 03:23
@github-actions github-actions bot temporarily deployed to pr-574 August 21, 2022 13:07 Destroyed
@github-actions github-actions bot temporarily deployed to pr-574 August 21, 2022 14:16 Destroyed
themightychris and others added 29 commits May 12, 2023 16:57
@themightychris @BillClinton
chore: remove debug lines
513a595
@themightychris @BillClinton
style: add missing space
1e211a4
@themightychris @BillClinton
test(e2e/api/student-competencies): rename test to ratings
0305cb6
@themightychris @BillClinton
fix(vscode): update studio ports for Chrome debuggers
8bec76a
@themightychris @BillClinton
feat: add weight and update override display in StudentCompetency det…
9795cf3 
…ail page
@themightychris @BillClinton
test(e2e/api/ratings): re-organize by endpoint
eb732d5
@themightychris @BillClinton
test(e2e/api/ratings): add test setting DemonstratedLevel to null
d3ba35d
@themightychris @BillClinton
test(e2e/api/ratings): add test ensuring ratings with no level/weight…
b7bad9c 
… set are kept and not changed
@themightychris @BillClinton
test(e2e/api/ratings): remove frivelous IDs
8f91fc4
@themightychris @BillClinton
fix(ratings): do not create new DemonstrationSkill records when no ra…
daa8e75 
…ting or weight provided
@themightychris @BillClinton
test(e2e/api/ratings): add test for adding rating
8735356
@themightychris @BillClinton
fix(ratings): delete any DemoSkills without ratings after processing …
39d0bcd 
…TaskSkills list
@themightychris @BillClinton
fix: order StudentTask.Skills by ID
58431e9
@themightychris @BillClinton
test(e2e/api/ratings): add student-tasks ratings API tests
659aed4
@themightychris @BillClinton
fix(ratings): update bumping of Ms by updated overrides
12a2acd
@themightychris @BillClinton
docs: fix typo
3902a13
@themightychris @BillClinton
fix: update recent-progress API for new override
c378200
@themightychris @BillClinton
fix: update student progress dashboard rendering of overrides
52999ba
@themightychris @BillClinton
feat: add demonstration opportunities to StudentCompetency detail page
4a5da8b
@themightychris @BillClinton
fix: update calculating opportunities with wildcard/non-1 weights
9bdae5b
@themightychris @BillClinton
fix: update teacher progress dashboard rendering of overrides
7118b0e
@themightychris @BillClinton
fix: update skill history window rendering of overrides
34c3f81
@themightychris @BillClinton
fix(ratings): update demonstration sorting for new overrides
f9daff8
@themightychris @BillClinton
fix: update legacy MRMF growth calculator for new overrides schema
6bf7b74
@themightychris @BillClinton
fix: update demonstrations exporter for new overrides schema
e4de367
@themightychris @BillClinton
fix: update Sencha fields/data for new overrides schema
ecaf23f
@themightychris @BillClinton
fix(portfolio-manager): update rendering for new overrides schema
9ff9468
@themightychris @BillClinton
test(e2e/api/ratings): remove hardcoded demoskill ID
a120a79
@BillClinton
Merge branch 'feat/ratings-backend' of github.com:SlateFoundation/sla…
5dfd337 
…te-cbl into feat/ratings-backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themightychris themightychris themightychris left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nbey @themightychris @chriscauley @ryon @BillClinton