Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(omnibar): ensure omnibar overlaps app content [#425] #772

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(omnibar): ensure omnibar overlaps app content [#425] #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sencha-workspace/packages/slate-cbl/sass/etc/all.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,8 @@
$level-colors-medium,
$level-colors-dark
);

div[id^='slate-cbl-'][id*='-picker'],
.x-css-shadow {
z-index: 10 !important;
}
Comment on lines +10 to +14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a good idea to monkey-patch the generated ExtJS styling like this, and the selector is liable to not catch everything ExtJS might put above the omnibar

A better approach instead of this would be to find the existing place where .slate-omnibar is assigned a z-index: 99 and set that to z-index: 999999 as our intention is that the omnibar should cover EVERYTHING. That way we don't have to get into whack-a-moleing specific things to be lower than it