Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DracFun to addon list #254

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Add DracFun to addon list #254

merged 1 commit into from
Oct 7, 2023

Conversation

PhoenixCodingStuff
Copy link
Contributor

Also when will my application be reviewed.

@PhoenixCodingStuff PhoenixCodingStuff requested a review from a team as a code owner October 3, 2023 13:16
@PhoenixCodingStuff
Copy link
Contributor Author

PhoenixCodingStuff commented Oct 3, 2023

I will probably open source in the future because lot of code is not complete and under comments👍
Also it is unoptimized asf. Even garbage is cleaner than the current code.
image
The requirements did not say it needs to be open source so I will update GitHub link in the future with PR
image

Also this is how it looks
image

@svr333
Copy link
Member

svr333 commented Oct 3, 2023

Your application for what?

While the requirements don't say it has to be open-source I think it is enforced? Though I'm not sure so @Sefiraat what do you think?

And personally I find that

I will probably open source in the future because lot of code is not complete and under comments

this should not be a reason to not open-source, sometimes code is just quick and messy but if it works it works, who cares what it looks like. Though that is just my opinion

@svr333 svr333 requested a review from Sefiraat October 3, 2023 15:12
@Sefiraat
Copy link
Member

Sefiraat commented Oct 3, 2023

Open source is a requirement for being on the builds repo but it's not one for the wiki as far as I know, and In my opinion I have no issues with it being closed here. That being said I do, without reservation, recommend you make it open source for many reasons. - regardless of your thoughts on its completeness and code quality. You will not be judged on that, but you may well be judged on the closed source nature, but that's your choice I guess.

@PhoenixCodingStuff
Copy link
Contributor Author

PhoenixCodingStuff commented Oct 3, 2023

Your application for what?

The addon community application

While the requirements don't say it has to be open-source I think it is enforced?

Fair, if that's the case I'll open PR after I complete it. Just few bits are left + Some optimization

pages/Addons.md Outdated Show resolved Hide resolved
@TheBusyBiscuit
Copy link
Member

I will probably open source in the future because lot of code is not complete and under comments👍
~Also it is unoptimized asf. [...]
The requirements did not say it needs to be open source so I will update GitHub link in the future with PR

Yep, that's fine 👍🏻
The projects do not need to be open-source to be listed here but open-source is undisputedly superior ;)

@PhoenixCodingStuff
Copy link
Contributor Author

for some reason pull bot reverted my changes, but I readded it

Copy link
Member

@Phoenix-Starlight Phoenix-Starlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully the pull bot doesn't force push this, no comments aside. Welcome to the addon list.

@Phoenix-Starlight Phoenix-Starlight merged commit f9a1219 into Slimefun:master Oct 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants