feat: add support for listing Schema apps by organization #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 69acdce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rossiam
commented
Aug 14, 2024
| @@ -259,8 +259,11 @@ export class SchemaEndpoint extends Endpoint { | |||
| /** | |||
| * Returns a list of all ST Schema C2C connectors belonging to the principal (i.e. the user) | |||
| */ | |||
| public async list(): Promise<SchemaApp[]> { | |||
| const response = await this.client.get<SchemaAppList>('apps') | |||
| public async list(options?: { includeAllOrganizations?: boolean }): Promise<SchemaApp[]> { | |||
There was a problem hiding this comment.
We have been doing this style of arguments more and more in the CLI but haven't much yet in the core SDK so it's maybe a little out-of-place for now but you have to start somewhere and calling code reads so much better when with it.
Sitlintac
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for requesting Schema Apps by organization.
Related CLI pull request:
SmartThingsCommunity/smartthings-cli#612