Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream branch, fix linting of md files and disable prettier t… #2

Closed
wants to merge 1 commit into from

Conversation

Smita81
Copy link
Owner

@Smita81 Smita81 commented Mar 12, 2024

…o prevent clash with ESLint rules (HackYourFutureBelgium#16)

  • just-enough-dom refactor, moving away from dom-io library. and more examples of multiple interactions

  • update study configs for multiple interactions

  • more READMEs, some more DOM IO, a formatting run (sorry!)

  • switch shift/unshift

  • linting fixed and prettier disabled to prevent eslint rule clash


Description

Checklists

General Checks

  • the branch is up to date with main/master
  • the code works when pulled and run locally
  • All CI checks pass
  • all conflicts are resolved (if any)
  • PR has a descriptive title
  • PR has appropriate labels and milestones for easy identification
  • PR it is assigned to the owner
  • reviewers are assigned
  • the PR contributes only one focused change
  • It is in the appropriate column in the project board (if necessary)
  • has short and clear description
  • is linked to an issue (if it is related)
  • feedback is addressed (if any and if it is appropriate feedback.)

Markdown

  • the markdown source is formatted
  • spelling and grammar is correct in all text
  • The markdown looks correct when you preview the file
  • all links and images work

…o prevent clash with ESLint rules (#16)

* just-enough-dom refactor, moving away from dom-io library.  and more examples of multiple interactions

* update study configs for multiple interactions

* more READMEs, some more DOM IO, a formatting run (sorry!)

* switch shift/unshift

* linting fixed and prettier disabled to prevent eslint rule clash

---------

Co-authored-by: Evan Cole <[email protected]>
@Smita81 Smita81 closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants